Hi Charles, On Tue, Dec 15, 2009 at 7:03 PM, Charles Oliver Nutter <[email protected]> wrote: > Ok, turns out we can't do this right now anyway because the CI > server's git is old enough that it doesn't have "submodule" and being > an older Ubuntu it's not easy to update it. We'll be moving CI to the > cloud this week, and then we can revisit this.
But why CI would even need to be aware of submodules? These are only sources, not used in builds or test runs. Users, who need submodules, could initialize them, others would just skip this and have everything like it is now, with no submodules at all. Thanks, --Vladimir P.S. When switching between revisions when there were no submodules and revisions with submodules, on Windows I get some error/warnings from git, it can't remove modules directories. Not major error, just warnings, looks like git on Windows has some (rather minimal) issues with submodules. > > On Tue, Dec 15, 2009 at 11:44 AM, Bob McWhirter <[email protected]> wrote: >> Yah, that sounds sane, then. >> >> -Bob >> >> >> On Dec 15, 2009, at 12:41 PM, Charles Oliver Nutter wrote: >> >>> On Tue, Dec 15, 2009 at 11:28 AM, Bob McWhirter <[email protected]> wrote: >>>> >>>> So, the issues with submodules is that users will have to remember to >>>> 'git >>>> submodule init' when they do a clone. >>>> >>>> Also, if you commit within a submodule, you *then* have to commit in the >>>> parent project so that HEAD in the parent includes a reference to the new >>>> HEAD in the submodule. That'll bite you a few times. >>>> >>>> I'd probably add some magic to build.xml to check if the submodules have >>>> been init'd, and do that for the user if required before attempting a >>>> build, >>>> or anything else meaningful. >>>> >>>> Fwiw, I started TorqueBox as a set of 6 repositories in a parent repo. >>>> It >>>> turned out to be a horrible mess for multi-project development. I ended >>>> up >>>> merging the repos together, and have been much happier since. >>> >>> These are just going to be read-only submodules for now, so if you >>> don't init them it won't really matter. They're mostly there so you >>> have access to them easily without going to fetch a separate >>> repository for each one. >>> >>> The builds will still operate against the pre-built binaries. Does >>> this sound ok? >>> >>> - Charlie >>> >>> --------------------------------------------------------------------- >>> To unsubscribe from this list, please visit: >>> >>> http://xircles.codehaus.org/manage_email >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> >> > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
