Thanks for driving the proposal Joel, I have a minor suggestion:  we should
be more clear about why we introduce this flag, so it would be better to
also state clearly in the document for the default behavior as well, such
like:

Comma-separated list of internal topics to be deleted. By default,
Streams reset tool will delete all topics prefixed by the
application.id.

This flag is useful when you need to keep certain topics intact due to
the prefix conflict with another application (such like "app" vs
"app-v2").

With provided internal topic names for "app", the reset tool will only
delete internal topics associated with "app", instead of both "app"
and "app-v2".


Other than that, +1 from me (binding).

On Wed, Jun 24, 2020 at 1:19 PM Joel Wee <joel....@outlook.com> wrote:

> Apologies. Changing the subject.
>
> On 24 Jun 2020, at 9:14 PM, Joel Wee <joel....@outlook.com<mailto:
> joel....@outlook.com>> wrote:
>
> Hi all
>
> I would like to start a vote for KIP-623, which adds the option
> --internal-topics to the streams-application-reset-tool:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862177
> .
>
> Please let me know what you think.
>
> Best
>
> Joel
>
>

Reply via email to