HI Ziming, thanks for the KIP. Looks good to me. Just on question: given that alterConfig is deprecated, shouldn't we also introduce --disable-incremental as deprecated? That way we would get rid of both in Kafka 4.0. Also see: https://issues.apache.org/jira/browse/KAFKA-14705.
On Tue, Dec 19, 2023 at 9:05 AM ziming deng <dengziming1...@gmail.com> wrote: > > Thank you for mention this Ismael, > > I added this to the motivation section, and I think we can still update > configs in this case by passing all sensitive configs, which is weird and not > friendly. > > -- > Best, > Ziming > > > On Dec 19, 2023, at 14:24, Ismael Juma <m...@ismaeljuma.com> wrote: > > > > Thanks for the KIP. I think one of the main benefits of the change isn't > > listed: sensitive configs make it impossible to make updates with the > > current cli tool because sensitive config values are never returned. > > > > Ismael > > > > On Mon, Dec 18, 2023 at 7:58 PM ziming deng <dengziming1...@gmail.com > > <mailto:dengziming1...@gmail.com>> wrote: > >> > >> Hello, I want to start a discussion on KIP-1011, to make the broker config > >> change path unified with that of user/topic/client-metrics and avoid some > >> bugs. > >> > >> Here is the link: > >> > >> KIP-1011: Use incrementalAlterConfigs when updating broker configs by > >> kafka-configs.sh - Apache Kafka - Apache Software Foundation > >> cwiki.apache.org > >> > >> > >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh>KIP-1011: > >> Use incrementalAlterConfigs when updating broker configs by > >> kafka-configs.sh - Apache Kafka - Apache Software Foundation > >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh> > >> cwiki.apache.org > >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh> > >> > >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1011%3A+Use+incrementalAlterConfigs+when+updating+broker+configs+by+kafka-configs.sh> > >> > >> Best, > >> Ziming. >
