Thank you for the summary, Ziming. Personally, I would prefer the latter i.e. having the incompatible change in 4.x instead of 3.x. This is because a major version upgrade goes through additional scrutiny by the users and usually comes with inevitable code changes required on the client. Hence, this incompatibility will be part of one amongst many changes that users will perform to upgrade to 4.x. This is unlike a major version change from 3.7 to 3.8 where users expect a simple upgrade without any code changes.
Let's wait and hear what others think about this. -- Divij Vaidya On Mon, Dec 25, 2023 at 1:18 PM ziming deng <dengziming1...@gmail.com> wrote: > Hello Divij Vaidya, > > You are right that users should update existing scripts to add > ‘—disable-incremental’, and you mentioned another upgrade path which is > similar, the summary of the 2 schemes are: > we change existing scripts to use `incrementalAlterConfigs` and add > "--disable-incremental" flag for old servers in Kafka 3.X, and remove it in > Kafka 4.X. > we keep existing scripts unchanged and add an "--enable-incremental" flag > for new servers in Kafka 3.X, and remove it in Kafka 4.X. > > I think there will always be an incompatible upgrade process to move > default behavior from `alterConfigs` to `incrementalConfigs`. In the first > scheme we are doing this incompatible upgrade in Kafka 3.X, and in the > second scheme we are moving it to 4.X, I think we should do it as soon as > possible if it's inevitable. > However, I will add this to <rejected alternatives>, and I'm open to this > if more people think it's more suitable. > > > --, > Ziming > > > On Dec 22, 2023, at 18:13, Divij Vaidya <divijvaidy...@gmail.com> wrote: > > > > Divij Vaidya > >
