Hello all, We have 2 people prefer using "--enable-incremental" and it makes sense to move the incompatible process to 4.X, I changed the default way to still use `alterConfigs` and use `incrementalAlterConfigs` only when "--enable-incremental" is specified.
I will initiate a vote process if no further opinions coming. Best, Ziming > On Dec 26, 2023, at 13:21, Kamal Chandraprakash > <kamal.chandraprak...@gmail.com> wrote: > > Hi Ziming, > > Thanks for the KIP! The proposal LGTM. > > I'm also inclined towards option 2 (i.e. add an explicit > --enable-incremental flag in 3.X version) > to avoid any incompatible change in v3.X. As mentioned in this thread, many > users might be > using external tools to do the topic rebalance and apply throttle config on > the brokers, it might > break for them when the tools are upgraded before the broker binary. > > cruise-control is currently using kafka-version: 3.1 > https://github.com/linkedin/cruise-control/blob/migrate_to_kafka_2_5/gradle.properties#L5 > > On Mon, Dec 25, 2023 at 7:15 PM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > >> Thank you for the summary, Ziming. >> >> Personally, I would prefer the latter i.e. having the incompatible change >> in 4.x instead of 3.x. This is because a major version upgrade goes through >> additional scrutiny by the users and usually comes with inevitable code >> changes required on the client. Hence, this incompatibility will be part of >> one amongst many changes that users will perform to upgrade to 4.x. This is >> unlike a major version change from 3.7 to 3.8 where users expect a simple >> upgrade without any code changes. >> >> Let's wait and hear what others think about this. >> >> -- >> Divij Vaidya >> >> >> >> On Mon, Dec 25, 2023 at 1:18 PM ziming deng <dengziming1...@gmail.com> >> wrote: >> >>> Hello Divij Vaidya, >>> >>> You are right that users should update existing scripts to add >>> ‘—disable-incremental’, and you mentioned another upgrade path which is >>> similar, the summary of the 2 schemes are: >>> we change existing scripts to use `incrementalAlterConfigs` and add >>> "--disable-incremental" flag for old servers in Kafka 3.X, and remove it >> in >>> Kafka 4.X. >>> we keep existing scripts unchanged and add an "--enable-incremental" flag >>> for new servers in Kafka 3.X, and remove it in Kafka 4.X. >>> >>> I think there will always be an incompatible upgrade process to move >>> default behavior from `alterConfigs` to `incrementalConfigs`. In the >> first >>> scheme we are doing this incompatible upgrade in Kafka 3.X, and in the >>> second scheme we are moving it to 4.X, I think we should do it as soon as >>> possible if it's inevitable. >>> However, I will add this to <rejected alternatives>, and I'm open to this >>> if more people think it's more suitable. >>> >>> >>> --, >>> Ziming >>> >>>> On Dec 22, 2023, at 18:13, Divij Vaidya <divijvaidy...@gmail.com> >> wrote: >>>> >>>> Divij Vaidya >>> >>> >>
