Hi David, Thanks for running the release. I performed the following steps: * Built from source using Java 17 * Enabled KIP-932 and ran through some basic actions to make sure it worked based on https://cwiki.apache.org/confluence/display/KAFKA/Queues+for+Kafka+%28KIP-932%29+-+Early+Access+Release+Notes * Validated the APIs enabled using kafka-broker-api-versions.sh * Stopped the broker and removed the config changes so KIP-932 was no longer enabled * Restarted the broker and validated the APIs enabled did not include KIP-932
All good. I also looked at the protocol docs and observe the following: * A bunch of APIs were removed in 4.0 (correct, of course) - these are not in the protocol docs * The APIs which are supported by the controller, such as Vote, are omitted from the protocol docs My view is that these APIs are supported in 4.0 and probably should be in the protocol docs. I haven't created an issue at this point because I'm not sure whether others will agree. Thanks, Andrew ________________________________________ From: Ismael Juma <m...@ismaeljuma.com> Sent: 26 February 2025 00:08 To: dev@kafka.apache.org <dev@kafka.apache.org> Subject: Re: [VOTE] 4.0.0 RC0 Hi Jun, When it comes to the upgrade documentation, a couple of changes landed after the RC was generated: * https://github.com/apache/kafka/commit/da8f390c4599d7199c4cdf2bb85441146e859b17 * https://github.com/apache/kafka/commit/da3b8e88dc61a1b749895866394cab68410e0eda Regarding the message format, I agree we can improve the documentation - I will submit a PR for that momentarily. Ismael On Tue, Feb 25, 2025 at 3:58 PM Jun Rao <j...@confluent.io.invalid> wrote: > Hi, David, > > Thanks for preparing RC0. > > A few comments on the documentation. > > 1.5 Upgrading > There is no documentation on which previous releases can be upgraded to > 4.0. > > 5.3.3 Old Message Format > Should we remove this section since 4.0 only supports the V2 message > format? > > 6.10 Consumer Rebalance Protocol > It's missing from the index on the left. > > ConsumerGroupPartitionAssignor is cut off in > org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionA. > > 6.11 Transaction Protocol > It's missing from the index on the left. > > Jun > > > On Tue, Feb 25, 2025 at 11:28 AM José Armando García Sancio > <jsan...@confluent.io.invalid> wrote: > > > Hi David and all, > > > > I am about to merge https://github.com/apache/kafka/pull/18852 to > > trunk: https://issues.apache.org/jira/browse/KAFKA-18723. I would like > > to cherry-pick it to 4.0.0. What do you think? > > > > I will also be cherry picking the change back to 3.7.x, 3.8.x and > > 3.9.x. If it is not included in the 4.0.0 release, we will need to > > include it in the 4.0.1 release. > > > > Thanks, > > -- > > -José > > >
