[ 
https://issues.apache.org/jira/browse/KAFKA-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174101#comment-14174101
 ] 

Neha Narkhede commented on KAFKA-1654:
--------------------------------------

[~jarcec] Thanks for the patch. Overall looks good. Few comments
1. The usage command says "USAGE: java [options] %s [kafka options] 
server.properties", but in order for the kafka options to take effect you also 
need to use --set. 
2. If you leave set out, it doesn't error out saying that --set is required and 
silently does not end up overriding the property value
3. Can we rename set to override?
4. If you specify multiple properties, it is unclear that you need to use --set 
for each of those. If you don't, it doesn't error out and silently doesn't 
override it.


> Provide a way to override server configuration from command line
> ----------------------------------------------------------------
>
>                 Key: KAFKA-1654
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1654
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.1.1
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1654.patch
>
>
> I've been recently playing with Kafka and I found the current way of server 
> configuration quite inflexible. All the configuration options have to be 
> inside a properties file and there is no way how they can be overridden for 
> execution.  In order to temporarily change one property I had to copy the 
> config file and change the property there. Hence, I'm wondering if people 
> would be open to provide a way how to specify and override the configs from 
> the command line when starting Kafka?
> Something like:
> {code}
> ./bin/kafka-server-start.sh -Dmy.cool.property=X kafka.properties
> {code}
> or 
> {code}
> ./bin/kafka-server-start.sh --set my.cool.property=X kafka.properties
> {code}
> I'm more than happy to take a stab at it, but I would like to see if there is 
> an interest for such capability?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to