[ 
https://issues.apache.org/jira/browse/KAFKA-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222284#comment-14222284
 ] 

Neha Narkhede commented on KAFKA-1654:
--------------------------------------

Thanks for the updated patch. Few more comments
1. The script for starting kafka ({{bin/kafka-server-start.sh}}) prints a 
different help message compared to the one in {{kafka.Kafka}}. Since that is 
the script used by everyone to start Kafka, it is worth fixing it there.
2. The properties have to be specified before the server.properties file. I 
found it more natural to specify it after the server.properties in the 
following manner.
{{bin/kafka-server-start.sh config/server.properties --override property=value}}
What do you think about this?

> Provide a way to override server configuration from command line
> ----------------------------------------------------------------
>
>                 Key: KAFKA-1654
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1654
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.1.1
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1654.patch, KAFKA-1654.patch, KAFKA-1654.patch
>
>
> I've been recently playing with Kafka and I found the current way of server 
> configuration quite inflexible. All the configuration options have to be 
> inside a properties file and there is no way how they can be overridden for 
> execution.  In order to temporarily change one property I had to copy the 
> config file and change the property there. Hence, I'm wondering if people 
> would be open to provide a way how to specify and override the configs from 
> the command line when starting Kafka?
> Something like:
> {code}
> ./bin/kafka-server-start.sh -Dmy.cool.property=X kafka.properties
> {code}
> or 
> {code}
> ./bin/kafka-server-start.sh --set my.cool.property=X kafka.properties
> {code}
> I'm more than happy to take a stab at it, but I would like to see if there is 
> an interest for such capability?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to