[ 
https://issues.apache.org/jira/browse/KAFKA-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201096#comment-14201096
 ] 

Jarek Jarcec Cecho commented on KAFKA-1654:
-------------------------------------------

Looking at feedback proposal more closely [~nehanarkhede], I wanted to explain 
a bit of my thinking. My intention is to add ability to specify command line 
arguments while starting Kafka broker similarly as we do have for the command 
line tools. In this patch I'm adding one argument only ({{--set}} that will be 
renamed to {{--override}} as you've suggested), that happens to have the 
ability to be specified multiple times. That explains why I'm expecting that 
you have to specify it for every property that is being overriden and also why 
I do have the [kafka options] section without mentioning that you have to use 
{{--set}} (you might want to add different parameter in the future, like 
completely bogus {{--disable-jmx}} or whatever :)). Perhaps I should have also 
submitted a second documentation patch to cover the usage. Does the reasoning 
resonate with you or would you prefer to simply add ability to override the 
config properties without opening the code to introduce additional command line 
arguments in the future? I'll definitely address the fact that I'm not properly 
failing on error cases, that is a huge problem in my mind - thank you for 
uncovering it!

> Provide a way to override server configuration from command line
> ----------------------------------------------------------------
>
>                 Key: KAFKA-1654
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1654
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.1.1
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1654.patch
>
>
> I've been recently playing with Kafka and I found the current way of server 
> configuration quite inflexible. All the configuration options have to be 
> inside a properties file and there is no way how they can be overridden for 
> execution.  In order to temporarily change one property I had to copy the 
> config file and change the property there. Hence, I'm wondering if people 
> would be open to provide a way how to specify and override the configs from 
> the command line when starting Kafka?
> Something like:
> {code}
> ./bin/kafka-server-start.sh -Dmy.cool.property=X kafka.properties
> {code}
> or 
> {code}
> ./bin/kafka-server-start.sh --set my.cool.property=X kafka.properties
> {code}
> I'm more than happy to take a stab at it, but I would like to see if there is 
> an interest for such capability?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to