----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92145 -----------------------------------------------------------
core/src/main/scala/kafka/admin/TopicCommand.scala (lines 56 - 62) <https://reviews.apache.org/r/36578/#comment146106> Nit: What changed here? Its always a good idea to keep non-functional changes very minimal. If there a re a lot of them, they can be addressed in a separate patch. Makes it easier to review functional changes. core/src/main/scala/kafka/admin/TopicCommand.scala (line 87) <https://reviews.apache.org/r/36578/#comment146107> I guess it is unnecessary to parse "0" as int. You can have maxMessageSize init to 0 and update if getProperty returns a non null value. core/src/main/scala/kafka/admin/TopicCommand.scala (line 119) <https://reviews.apache.org/r/36578/#comment146108> Non-func change? core/src/main/scala/kafka/admin/TopicCommand.scala (line 129) <https://reviews.apache.org/r/36578/#comment146109> Non-func change? core/src/main/scala/kafka/admin/TopicCommand.scala (line 145) <https://reviews.apache.org/r/36578/#comment146110> Non-func change? - Ashish Singh On July 17, 2015, 7:32 p.m., Edward Ribeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36578/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 7:32 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2338 > https://issues.apache.org/jira/browse/KAFKA-2338 > > > Repository: kafka > > > Description > ------- > > KAFKA-2338 Warn users if they change max.message.bytes that they also need to > update broker and consumer settings > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > a90aa8787ff21b963765a547980154363c1c93c6 > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > f84306143c43049e3aa44e42beaffe7eb2783163 > > Diff: https://reviews.apache.org/r/36578/diff/ > > > Testing > ------- > > > Thanks, > > Edward Ribeiro > >
