> On July 18, 2015, 12:10 a.m., Ashish Singh wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, lines 56-62 > > <https://reviews.apache.org/r/36578/diff/1/?file=1014811#file1014811line56> > > > > Nit: What changed here? Its always a good idea to keep non-functional > > changes very minimal. If there a re a lot of them, they can be addressed in > > a separate patch. Makes it easier to review functional changes.
You right. Gonna fix this one and unrelated changes below. - Edward ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/#review92145 ----------------------------------------------------------- On July 17, 2015, 7:32 p.m., Edward Ribeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36578/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 7:32 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2338 > https://issues.apache.org/jira/browse/KAFKA-2338 > > > Repository: kafka > > > Description > ------- > > KAFKA-2338 Warn users if they change max.message.bytes that they also need to > update broker and consumer settings > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > a90aa8787ff21b963765a547980154363c1c93c6 > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > f84306143c43049e3aa44e42beaffe7eb2783163 > > Diff: https://reviews.apache.org/r/36578/diff/ > > > Testing > ------- > > > Thanks, > > Edward Ribeiro > >
