----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92465 -----------------------------------------------------------
Thanks for the patch, some comments. core/src/main/scala/kafka/network/SocketServer.scala (lines 234 - 235) <https://reviews.apache.org/r/36652/#comment146660> We probably want to keep the try-catch inside the while loop. core/src/main/scala/kafka/network/SocketServer.scala (line 235) <https://reviews.apache.org/r/36652/#comment146661> Open source Kafka convention is to put the bracket on the same line. T - Jiangjie Qin On July 21, 2015, 8:11 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 8:11 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 91319fa010b140cca632e5fa8050509bd2295fc9 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
