> On July 21, 2015, 8:26 p.m., Grant Henke wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 266 > > <https://reviews.apache.org/r/36652/diff/1/?file=1018073#file1018073line266> > > > > What errors were seen that should be caught here? Can we catch a more > > specific exception and provide a better message? > > Mayuresh Gharat wrote: > The nioSelector can throw different exceptions : IOException, > ClosedSelectorException, IllegalArgumentException. We can have different > catch for each of them. But we thought that the log will telll us what > exception was thrown when we pass it to error()
I assumed you are adding this because you saw a specific error. I wasn't sure what error you saw and if more context could be given to the user. Perhaps the error you saw is fairly common during shutdown and should be ignored, and not logged at the error level. But all others should be handle as you are here. - Grant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92470 ----------------------------------------------------------- On July 21, 2015, 8:11 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 8:11 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 91319fa010b140cca632e5fa8050509bd2295fc9 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
