----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92928 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala (line 264) <https://reviews.apache.org/r/36652/#comment147193> Hi Jun, Cleaning up in finally is actually nice. I will make the necessary change and upload a new patch. I was looking at the patch for : https://issues.apache.org/jira/browse/KAFKA-2353 as per the suggestions on the jira ticket. Was just curious if we can do the same there as well. We are catching all the Throwables and allowing the thread to continue processing. Is there something I am missing here. - Mayuresh Gharat On July 24, 2015, 4:36 a.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 4:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Addressed comments on the Jira ticket > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 91319fa010b140cca632e5fa8050509bd2295fc9 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
