Hey Vahid, What I meant was that the OffsetFetch request includes an array of topic partitions, just like the TopicMetadata request. So similar to that API, we could use a null array in order to fetch all offsets for a given groupId. Then there's the matter of how to expose the capability. Adding the API to KafkaConsumer as you've suggested seems reasonable, but I could also see it exposed on the AdminClient, which would eliminate the need to create the "dummy" consumer. What do you think?
Thanks, Jason On Mon, Nov 7, 2016 at 3:28 PM, Vahid S Hashemian <vahidhashem...@us.ibm.com > wrote: > Hi Jason, > > Thanks for your feedback. > > Yes, the intent of the KIP is to make existing offsets of the group > available even when there is no active consumers in the group consuming > from one or more topic partitions. > Your suggestion should also work. I'm not yet sure how to obtain group's > all topic partitions and need to look more closely at your 'null=all' > suggestion, as I couldn't immediately see an obvious way to extract that > info in the OffsetFetch handler. I'll dig deeper. > Just a quick note that using the OffsetFetch API would not address the > second (but minor) problem described in the current KIP (the dummy group > member). I assume that is not a big concern. > > Thanks. > --Vahid > > > > > From: Jason Gustafson <ja...@confluent.io> > To: dev@kafka.apache.org > Date: 11/07/2016 09:19 AM > Subject: Re: [DISCUSS] KIP 88: DescribeGroups Protocol Update > > > > Hey Vahid, > > Thanks for the KIP. If I understand correctly, the problem is how to fetch > existing offsets for a group which has no active members, right? I'm not > totally clear why we need to modify the DescribeGroups API in order to > achieve this since we already have the OffsetFetch API. I think the > limitation currently is that you need to know the partitions to fetch > offsets for, but perhaps we could modify it to support the "null=all" > semantics that we used for the TopicMetadata API? > > Thanks, > Jason > > On Thu, Nov 3, 2016 at 11:09 AM, Vahid S Hashemian < > vahidhashem...@us.ibm.com> wrote: > > > Hi all, > > > > I started a new KIP under > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 88%3A+DescribeGroups+Protocol+Update > > . > > > > The KIP is a proposal to update the DescribeGroups protocol to address > > KAFKA-3853 (https://issues.apache.org/jira/browse/KAFKA-3853). > > > > I appreciate your feedback. > > > > Thanks. > > --Vahid > > > > > > > > >
