Thanks for the votes! Jason: I updated the KIP so that the messageFormatVersion field is int8.
Guozhang: The type of the config field is a purely internal concept. The public API of the KafkaProducer takes a Map<String, Object> type or a Properties type (which is a map of String to String). So this change in the type doesn't change anything from an external point of view. Thanks, Apurva On Thu, Sep 7, 2017 at 2:45 PM, Guozhang Wang <wangg...@gmail.com> wrote: > +1. > > A quick clarification question regarding the compatibility plan as for "The > legacy values for `enable.idempotence` will be interpreted as follows by > the new producer: true will mean required, false will mean off." > > Right now "enable.idempotence" is defined as Type.BOOLEAN while we are > likely to change it to Type.STRING, is that considered compatible? > > > Guozhang > > > On Thu, Sep 7, 2017 at 2:25 PM, Jason Gustafson <ja...@confluent.io> > wrote: > > > +1. Thanks for the KIP. One nit: we could use int8 to represent the > message > > format version. That is how it is represented in the messages themselves. > > > > -Jason > > > > On Thu, Sep 7, 2017 at 1:51 PM, Apurva Mehta <apu...@confluent.io> > wrote: > > > > > Hi, > > > > > > I'd like to start a vote for KIP-192: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 192+%3A+Provide+cleaner+semantics+when+idempotence+is+enabled > > > > > > Thanks, > > > Apurva > > > > > > > > > -- > -- Guozhang >
