Thanks Guillaume for looking at it :-) 2015-04-17 9:50 GMT+02:00 Guillaume Nodet <[email protected]>:
> Ah, I think I found what you are referring to, that's KARAF-3601. > Martin is using features-add-to-repository, but not to build a custom > distribution directly. > I'll undelete it ;-) > > 2015-04-17 9:30 GMT+02:00 Guillaume Nodet <[email protected]>: > > > Ah, good point, I missed that. > > I don't think it was on dev, I'll try to find the email. > > > > > > 2015-04-17 8:58 GMT+02:00 Achim Nierbeck <[email protected]>: > > > >> Hi > >> > >> I can't remember if it's been on the mailinglist or in the issue, but a > >> user of our maven plugin just mentioned > >> he uses one of the to-be-deleted goals for documentation purposes. > >> Just as a little reminder, don't know if you had it on your screen, that > >> we > >> should consider those use-cases maybe usefull :-) > >> > >> regards, Achim > >> > >> > >> 2015-04-17 5:30 GMT+02:00 Freeman Fang <[email protected]>: > >> > >> > +1 for first set of names. > >> > > >> > Thanks > >> > －－－－－－－－－－－－－ > >> > Freeman(Yue) Fang > >> > > >> > Red Hat, Inc. > >> > FuseSource is now part of Red Hat > >> > > >> > > >> > > >> > On 2015-4-16, at 下午10:49, Guillaume Nodet wrote: > >> > > >> > > I created KARAF-3671 for this discussion. > >> > > > >> > > I'm proposing the following: > >> > > * remove features-add-to-repository goal > >> > > * remove the features-validate-descriptor > >> > > * rename install-kars goal to *assembly* > >> > > * rename instance-create-archive to *archive* > >> > > * rename verify-features to *verify* > >> > > * rename features-create-kar to *kar* > >> > > > >> > > The other goals are: > >> > > * features-export-meta-data > >> > > * features-generate-descriptor > >> > > * commands-generate-help > >> > > and we'd have to find names more > >> > > > >> > > I'm not really sure the features-generate-descriptor is widely used. > >> Is > >> > it > >> > > ? > >> > > > >> > > For the naming, another option is to keep the [resource]-[action] > >> idiom: > >> > > * assembly-create > >> > > * assembly-archive > >> > > * kar-create > >> > > * commands-generate-help > >> > > * features-verify > >> > > * features-generate-descriptor > >> > > * features-export-meta-data > >> > > > >> > > The first option seems more inline with usual maven plugins, and > they > >> > look > >> > > nicer to me, but I don't really mind. > >> > > Thoughts ? > >> > > > >> > > > >> > > 2015-04-08 12:44 GMT+02:00 Guillaume Nodet <[email protected]>: > >> > > > >> > >> In master, the karat-maven-plugin contains the following goals: > >> > >> * features-add-to-repository > >> > >> * features-create-kar > >> > >> * features-export-meta-data > >> > >> * features-generate-descriptor > >> > >> * install-kars > >> > >> * features-validate-descriptor > >> > >> * verify-features > >> > >> > >> > >> The features-add-to-repository mojo seems somewhat redundant with > the > >> > >> install-kars mojo which is used to build our own distribution. The > >> > >> features-export-meta-data seems redundant with the > >> > >> features-generate-descriptor, and the features-validate-descriptor > >> seems > >> > >> redundant with the verify-features goal. > >> > >> > >> > >> Am I missing something, or should we get rid of the > >> > >> features-add-to-repository, features-export-meta-data and > >> > >> features-generate-descriptor goals for 4.0 ? > >> > >> > >> > >> Cheers, > >> > >> Guillaume > >> > >> > >> > > >> > > >> > >> > >> -- > >> > >> Apache Member > >> Apache Karaf <http://karaf.apache.org/> Committer & PMC > >> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> > Committer & > >> Project Lead > >> blog <http://notizblog.nierbeck.de/> > >> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> > >> > >> Software Architect / Project Manager / Scrum Master > >> > > > > > -- Apache Member Apache Karaf <http://karaf.apache.org/> Committer & PMC OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead blog <http://notizblog.nierbeck.de/> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> Software Architect / Project Manager / Scrum Master
