+1
It sounds reasonable.
Regards
JB
On 10/19/2016 02:40 PM, Guillaume Nodet wrote:
So I'll go ahead with the following:
* change the verify goal to be a default goal for the feature packaging
* change the feature-generate-descriptor to be a non default goal for the
feature packaging
The benefits is that people who want to hand-write features will be able to
use the feature packaging, while those who want to use the generator will
have to add this goal to their build.
I've raised KARAF-4787 for that.
2016-10-13 11:07 GMT+02:00 Guillaume Nodet <[email protected]>:
The feature packaging is a nice thing, as it allows automatic attachment
of the feature file.
However, it always use the feature-generate-descriptor, which produces a
lot of weird results.
Afaik, the feature packaging is not much used and all projects i've seen,
such as pax projects, camel, cxf, and even karaf itself (including
decanter, cellar, karaf container...).
I think part of the problem comes from the feature descriptor generation,
which is difficult to control. I have always found much easier to simply
write the feature manually.
Although the generation process rewrites the xml entirely, so that any xml
comments or license header is lost.
Overall, I'm not sure that it makes our users life really easier.
So I'd like to propose to get rid of the feature-generate-descriptor from
inside the feature packaging and replace it with the verify goal to
validate the hand-written features instead.
Thoughts ?
--
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration
Email: [email protected]
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
