I don't think it's good idea to include repo name or id in the name (and it's already possible to identify features that way). However I agree that we should have unique name.
Regards JB On Jun 10, 2017, 18:16, at 18:16, Christian Schneider <[email protected]> wrote: >+1 for the removal of the jpa feature in karaf. > >I also agree that feature names are not unique enough. Probably we need >repo id or url + feature name. > >Christian > >2017-06-10 16:22 GMT+02:00 Achim Nierbeck <[email protected]>: > >> Hi, >> >> just recently I stumbled over a strange effect while building a >customized >> Karaf with boot features. >> In the end it turned out, the reason for that had been two features >with >> the same name but not the same content. >> >> Right now we do have a jpa feature in the enterprise repository >> (feature.xml) in version 2.6.0 >> While the same feature name exists from the aries repository >(feature.xml) >> also in version 2.6.0 >> >> I opened an issue for this: >> https://issues.apache.org/jira/browse/KARAF-5185 >> right now I'm in favor of dumping the jpa feature in the enterprise >> repository in favor of the aries jpa feature. If there are no >objections >> I'd start to remove the enterprise feature. >> >> In general though we can't really expect to have unique feature names >only >> by the feature name itself. Maybe it's time to take the repository >also >> into account as coordinate for feature declarations? >> >> regards, Achim >> >> -- >> >> Apache Member >> Apache Karaf <http://karaf.apache.org/> Committer & PMC >> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> >Committer & >> Project Lead >> blog <http://notizblog.nierbeck.de/> >> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >> >> Software Architect / Project Manager / Scrum Master >> > > > >-- >-- >Christian Schneider >http://www.liquid-reality.de ><https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.liquid-reality.de> > >Open Source Architect >http://www.talend.com ><https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.talend.com>
