Starting from the example or archetype works. So, I will add a note about that (for sure, framework should not be included in the set, it's added by the plugin). Anyway, I started a complete refactoring of the custom distribution creation.
Regards JB On 09/01/2019 14:38, James Carman wrote: > To make my example, I copied the featuresBoot from a downloaded version of > Karaf 4.2.2: > > featuresBoot = \ > instance/4.2.2, \ > package/4.2.2, \ > log/4.2.2, \ > ssh/4.2.2, \ > framework/4.2.2, \ > system/4.2.2, \ > eventadmin/4.2.2, \ > feature/4.2.2, \ > shell/4.2.2, \ > management/4.2.2, \ > service/4.2.2, \ > jaas/4.2.2, \ > deployer/4.2.2, \ > diagnostic/4.2.2, \ > wrap/2.5.4, \ > bundle/4.2.2, \ > config/4.2.2, \ > kar/4.2.2 > > It appears that when I add "framework" to the list of <bootFeatures>, it > causes this issue. If I omit it, then the startup.properties file > generates properly. I would imagine this is a common occurrence, for folks > to want to start with a "vanilla" setup and customize from there (seemed > logical to me). It looks like the "framework" feature shouldn't be > included in the list, but would be added by the presence of its KAR file: > > [INFO] Loading direct KAR and features XML dependencies > [INFO] Standard startup Karaf KAR found: > mvn:org.apache.karaf.features/framework/4.2.2/kar > [INFO] Feature framework will be added as a startup feature > > Maybe we should provide some more docs (or perhaps I missed them) around > how these different frameworks are selected/installed when using this maven > plugin? > > On Wed, Jan 9, 2019 at 1:22 AM Jean-Baptiste Onofré <[email protected]> wrote: > >> No, as the example just works fine: the etc/startup.properties is >> populated and the distribution starts without problem. >> >> Regards >> JB >> >> On 09/01/2019 06:37, James Carman wrote: >>> We should likely update the example? >>> >>> >> https://github.com/apache/karaf/blob/master/examples/karaf-maven-example/karaf-maven-example-assembly/pom.xml >>> >>> >>> On Wed, Jan 9, 2019 at 12:02 AM Jean-Baptiste Onofré <[email protected]> >>> wrote: >>> >>>> Hi James, >>>> >>>> I wasn't clear sorry. You need the framework features (in addition of >>>> kar) with runtime scope. >>>> >>>> I also see that the install kar is not performed by the karaf-assembly. >>>> >>>> I created a PR on your project fixing the issues. >>>> >>>> Anyway, it confirms what I sent some weeks ago: creating a custom >>>> distribution is not as simple as it should. I will simplify this. >>>> >>>> Regards >>>> JB >>>> >>>> On 08/01/2019 20:50, James Carman wrote: >>>>> When I change the kar scope to "provided", I get: >>>>> >>>>> Failed to execute goal >>>>> org.apache.karaf.tooling:karaf-maven-plugin:4.2.2:assembly >>>>> (default-assembly) on project custom-karaf-example: Unable to build >>>>> assembly: Can't determine framework to use (framework, >> framework-logback, >>>>> static-framework, static-framework-logback, custom). Please specify >> valid >>>>> "framework" option or add Maven dependency with "kar" type and >> "compile" >>>>> scope for one of standard Karaf KARs. >>>>> >>>>> I have updated the example I linked above to reflect the change. Did I >>>> do >>>>> something wrong? >>>>> >>>>> On Tue, Jan 8, 2019 at 2:24 PM Jean-Baptiste Onofré <[email protected]> >>>> wrote: >>>>> >>>>>> Exactly, the scope should be provided ;) >>>>>> >>>>>> Regards >>>>>> JB >>>>>> >>>>>> On 08/01/2019 19:11, James Carman wrote: >>>>>>> On Tue, Jan 8, 2019 at 12:59 PM Jean-Baptiste Onofré < >> [email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi James, >>>>>>>> >>>>>>>> no the startup.properties is generated by the plugin, using the >> scope. >>>>>>>> So, karaf framework kar is probably missing in your project. >>>>>>>> >>>>>>>> >>>>>>> You mean this? >>>>>>> >>>>>>> >>>>>> >>>> >> https://github.com/jwcarman/custom-karaf-example/blob/vanilla/pom.xml#L18 >>>>>>> >>>>>> >>>>>> -- >>>>>> Jean-Baptiste Onofré >>>>>> [email protected] >>>>>> http://blog.nanthrax.net >>>>>> Talend - http://www.talend.com >>>>>> >>>>> >>>> >>>> -- >>>> Jean-Baptiste Onofré >>>> [email protected] >>>> http://blog.nanthrax.net >>>> Talend - http://www.talend.com >>>> >>> >> >> -- >> Jean-Baptiste Onofré >> [email protected] >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> > -- Jean-Baptiste Onofré [email protected] http://blog.nanthrax.net Talend - http://www.talend.com
