[
https://issues.apache.org/jira/browse/KNOX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283797#comment-14283797
]
Larry McCay commented on KNOX-485:
----------------------------------
Hi [~andreina] - I see what you mean.
There are some obsolete descriptions and possibly configuration items in there.
Thank you for this observation and initial patch.
Let's make a couple changes to the patch:
* we need a test for ensuring that the default deployments location still works
* we need a test for ensuring that it can be overridden with your change (see
GatewayGlobalConfigTest.java for both of these)
* I think that we need to leave the gateway.gateway.conf.dir element in there
for now. You are correct in that deployments do not belong in that directory
anymore but we need to consider making the conf directory configurable - there
are obviously some challenges there but this should be considered as a separate
issue. (I will file a separate jira for that task)
Thanks again for the contribution here!
> Gateway deployment directory value is been hardcoded , instead of value being
> read from exposed configuration.
> --------------------------------------------------------------------------------------------------------------
>
> Key: KNOX-485
> URL: https://issues.apache.org/jira/browse/KNOX-485
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.5.0
> Reporter: J.Andreina
> Attachments: KNOX-485.1.patch
>
>
> Issue1 :
> ======
> During Gateway startup , deployment directory value is been hardcoded ,
> instead of value being read from available configuration .
> {noformat}
> @Override
> public String getGatewayDeploymentDir() {
> return getGatewayDataDir() + File.separator + "deployments";
> }
> {noformat}
> Issue2:
> ======
> Configuration Name in gateway-default.xml is not same as the name used in
> "org.apache.hadoop.gateway.config.impl.GatewayConfigImpl"
> {noformat}
> private static final String GATEWAY_CONFIG_FILE_PREFIX = "gateway";
> public static final String DEPLOYMENT_DIR = GATEWAY_CONFIG_FILE_PREFIX +
> ".deployment.dir";
> {noformat}
> Incorrect Configuration name in gateway-default.xml
> {noformat}
> <property>
> <name>gateway.gateway.conf.dir</name>
> <value>deployments</value>
> <description>The directory within GATEWAY_HOME that contains gateway
> topology deployments.</description>
> </property>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
