[ 
https://issues.apache.org/jira/browse/KNOX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289137#comment-14289137
 ] 

Larry McCay commented on KNOX-485:
----------------------------------

I don't think that there would be any problem with configuring the whole data 
directory location.
However, if your requirement is that each subdir be on a separate disk then 
perhaps we should continue down this path since configuring the data dir level 
would have them all in the same place. It is worth noting that not all like 
directories have all of their contents in separate subdirs. Config has much of 
it directly in the config directory but also has a topologies directory.

We may want to additionally provide the configurability for the whole data 
directory for other usecases where the whole thing should be relocated to the 
same place. The same would need to be provided for config as well - of course 
that one is a little trickier.

If you are comfortable moving forward with the individual subdir approach then 
I think we can provide that flexibility without hurting anything and a separate 
jira to do so would be fine.

> Gateway deployment directory value is been hardcoded , instead of value being 
> read from exposed configuration.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: KNOX-485
>                 URL: https://issues.apache.org/jira/browse/KNOX-485
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.5.0
>            Reporter: J.Andreina
>         Attachments: KNOX-485.1.patch, KNOX-485.2.patch, KNOX-485.3.patch
>
>
> Issue1 :
> ======
> During Gateway startup , deployment directory value is been hardcoded , 
> instead of value being read from available configuration .
> {noformat}
>   @Override
>   public String getGatewayDeploymentDir() {
>     return getGatewayDataDir() + File.separator + "deployments";
>   }
> {noformat}
> Issue2:
> ======
>    Configuration Name in gateway-default.xml is not same as the name used in 
> "org.apache.hadoop.gateway.config.impl.GatewayConfigImpl"
> {noformat}
>   private static final String GATEWAY_CONFIG_FILE_PREFIX = "gateway";
>   public static final String DEPLOYMENT_DIR = GATEWAY_CONFIG_FILE_PREFIX + 
> ".deployment.dir";
> {noformat}
> Incorrect Configuration name in gateway-default.xml
> {noformat}
>     <property>
>         <name>gateway.gateway.conf.dir</name>
>         <value>deployments</value>
>         <description>The directory within GATEWAY_HOME that contains gateway 
> topology deployments.</description>
>     </property>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to