[
https://issues.apache.org/jira/browse/KNOX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287388#comment-14287388
]
Larry McCay commented on KNOX-485:
----------------------------------
Hi [~andreina] - Thank you for the revised patch!
As I review this, I am reminded that I'd like to make sure that this change
actually meets your needs.
While it is proper to fix this obsolete code, I want to make sure that it is
clear that this configurability is limited to specifying the directory for the
deployments *within* the data directory. I can't imagine a usecase that
requires this configurability that would be happy with it still being in the
[GATEWAY_HOME]/data/xxx directory.
If you could articulate your usecase - that would be great.
The only issue that I see in the patch is that the description is still
obsolete - in that, it states that the topology files are in this directory as
well. They are no longer colocated with the deployments and are located in the
[GATEWAY_HOME]/conf/topologies directory instead.
Would you mind fixing the description for the config element in another
revision?
Thanks again!
> Gateway deployment directory value is been hardcoded , instead of value being
> read from exposed configuration.
> --------------------------------------------------------------------------------------------------------------
>
> Key: KNOX-485
> URL: https://issues.apache.org/jira/browse/KNOX-485
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.5.0
> Reporter: J.Andreina
> Attachments: KNOX-485.1.patch, KNOX-485.2.patch
>
>
> Issue1 :
> ======
> During Gateway startup , deployment directory value is been hardcoded ,
> instead of value being read from available configuration .
> {noformat}
> @Override
> public String getGatewayDeploymentDir() {
> return getGatewayDataDir() + File.separator + "deployments";
> }
> {noformat}
> Issue2:
> ======
> Configuration Name in gateway-default.xml is not same as the name used in
> "org.apache.hadoop.gateway.config.impl.GatewayConfigImpl"
> {noformat}
> private static final String GATEWAY_CONFIG_FILE_PREFIX = "gateway";
> public static final String DEPLOYMENT_DIR = GATEWAY_CONFIG_FILE_PREFIX +
> ".deployment.dir";
> {noformat}
> Incorrect Configuration name in gateway-default.xml
> {noformat}
> <property>
> <name>gateway.gateway.conf.dir</name>
> <value>deployments</value>
> <description>The directory within GATEWAY_HOME that contains gateway
> topology deployments.</description>
> </property>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
