risdenk commented on a change in pull request #56: KNOX-1756 - Knox Gateway TLS
Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#discussion_r259002788
##########
File path:
gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java
##########
@@ -91,6 +91,11 @@ public String getGatewaySecurityDir() {
return gatewayHomeDir + "/security";
}
+ @Override
+ public String getGatewayKeystoreDir() {
+ return getGatewaySecurityDir() + "/keystores";
Review comment:
Ew - didn't realize that there were other examples that are hardcoded with
`/`. I think either we fix them all in this file or don't fix it with this PR
and do it in a followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
