risdenk commented on a change in pull request #56: KNOX-1756 - Knox Gateway TLS
Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#discussion_r259004714
##########
File path:
gateway-test/src/test/java/org/apache/knox/gateway/AmbariServiceDefinitionTest.java
##########
@@ -352,4 +366,28 @@ public void contextPathInViewsResponse() throws Exception
{
LOG_EXIT();
}
+ private static void createTestKeystore()
Review comment:
Hmmmm - Not sure if it is possible to move the create test keystore method
from `GatewayTestDriver` to `gateway-test-utils` module `TestUtils`? It looks
like it relies on stuff in `gateway-server` like `X509CertificateUtil`.
Just seems really ugly to have this block of code copied around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
