risdenk commented on a change in pull request #56: KNOX-1756 - Knox Gateway TLS 
Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#discussion_r259009955
 
 

 ##########
 File path: 
gateway-test/src/test/java/org/apache/knox/gateway/AmbariServiceDefinitionTest.java
 ##########
 @@ -352,4 +366,28 @@ public void contextPathInViewsResponse() throws Exception 
{
     LOG_EXIT();
   }
 
+  private static void createTestKeystore()
 
 Review comment:
   Actually - `X509CertificateUtil` is in `gateway-spi` so shouldn't be too bad 
to move to `TestUtils`. This should avoid needing an additional dependency in 
most cases. Much easier to add a test dependency on `gateway-test-utils` than 
on `gateway-test-release-utils`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to