[
https://issues.apache.org/jira/browse/KNOX-1191?focusedWorklogId=202762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202762
]
ASF GitHub Bot logged work on KNOX-1191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 17:46
Start Date: 22/Feb/19 17:46
Worklog Time Spent: 10m
Work Description: moresandeep commented on pull request #57: KNOX-1191 -
Azure AD support for KnoxSSO
URL: https://github.com/apache/knox/pull/57
## What changes were proposed in this pull request?
Currently OIDC support for Azure AD was broken. This is because Azure AD
does not allow ? in callback urls. This fix updates the callback flow in Knox
so that the callback urls now can have callback parameter as a path element
rather than a query parameter.
## How was this patch tested?
This patch was manually tested with Azure AD (OIDC), Google (OIDC) and Okta
(SAML) authentication providers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202762)
Time Spent: 10m
Remaining Estimate: 0h
> Implement Azure AD support for Knox SSO
> ---------------------------------------
>
> Key: KNOX-1191
> URL: https://issues.apache.org/jira/browse/KNOX-1191
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxSSO
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Due to the way Azure AD mangles the callback URL, Knox
> Pac4jDispatcherFilter has issues intercepting the callback url and the
> request ends up in a redirect loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
