[
https://issues.apache.org/jira/browse/KNOX-1191?focusedWorklogId=202808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202808
]
ASF GitHub Bot logged work on KNOX-1191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 19:17
Start Date: 22/Feb/19 19:17
Worklog Time Spent: 10m
Work Description: moresandeep commented on pull request #57: KNOX-1191 -
Azure AD support for KnoxSSO
URL: https://github.com/apache/knox/pull/57#discussion_r259476448
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##########
@@ -160,8 +179,17 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
} else {
clientName = clientNameParameter;
}
+
+ /* special handling for Azure AD, use path separators instead of query
params */
+ clients.forEach( client -> {
+ if(client.getName().equalsIgnoreCase(PAC4J_AZURE_AD_CLIENT)) {
+ ((AzureAdClient)client).setCallbackUrlResolver(new
PathParameterCallbackUrlResolver());
Review comment:
This is a good suggestion, actually now I think there might be a bug if
someone just uses Oidc client and not specify Azure (the code should work for
both), I'll fix this, thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202808)
Time Spent: 1h (was: 50m)
> Implement Azure AD support for Knox SSO
> ---------------------------------------
>
> Key: KNOX-1191
> URL: https://issues.apache.org/jira/browse/KNOX-1191
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxSSO
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Due to the way Azure AD mangles the callback URL, Knox
> Pac4jDispatcherFilter has issues intercepting the callback url and the
> request ends up in a redirect loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
