[
https://issues.apache.org/jira/browse/KNOX-1191?focusedWorklogId=202772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202772
]
ASF GitHub Bot logged work on KNOX-1191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 18:02
Start Date: 22/Feb/19 18:02
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #57: KNOX-1191 -
Azure AD support for KnoxSSO
URL: https://github.com/apache/knox/pull/57#discussion_r259451288
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java
##########
@@ -176,6 +211,25 @@ public void set(WebContext context, String key, Object
value) {
}
}
+ /**
+ * Keep only the fileds that are needed for Pac4J.
+ * Used to reduce the cookie size.
+ * @param value profile object
+ * @return trimmed profile object
+ * @since 1.3.0
+ */
+ private Object clearUserProfile(final Object value) {
+ if(value instanceof LinkedHashMap<?,?>) {
Review comment:
Could this be any Map instead of a LinkedHashMap? Just thinking if profiles
Map impl could change later but would still have the same underlying interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202772)
Time Spent: 40m (was: 0.5h)
> Implement Azure AD support for Knox SSO
> ---------------------------------------
>
> Key: KNOX-1191
> URL: https://issues.apache.org/jira/browse/KNOX-1191
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxSSO
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Due to the way Azure AD mangles the callback URL, Knox
> Pac4jDispatcherFilter has issues intercepting the callback url and the
> request ends up in a redirect loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
