risdenk commented on a change in pull request #57: KNOX-1191 - Azure AD support for KnoxSSO URL: https://github.com/apache/knox/pull/57#discussion_r259450754
########## File path: gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java ########## @@ -75,12 +77,18 @@ public static final String PAC4J_CALLBACK_PARAMETER = "pac4jCallback"; + public static final String PAC4J_AZURE_AD_CLIENT = "AzureAdClient"; + + public static final String URL_PATH_SEPARATOR = "/"; Review comment: nit: I would guess that there is already a constant for this from HTTP client or something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
