risdenk commented on a change in pull request #57: KNOX-1191 - Azure AD support for KnoxSSO URL: https://github.com/apache/knox/pull/57#discussion_r259495978
########## File path: gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java ########## @@ -75,12 +77,18 @@ public static final String PAC4J_CALLBACK_PARAMETER = "pac4jCallback"; + public static final String PAC4J_AZURE_AD_CLIENT = "AzureAdClient"; + + public static final String URL_PATH_SEPARATOR = "/"; Review comment: Well you are probably right since I couldn't find any. Surprising :( https://hc.apache.org/httpcomponents-core-ga/httpcore/apidocs/constant-values.html ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
