risdenk commented on a change in pull request #57: KNOX-1191 - Azure AD support
for KnoxSSO
URL: https://github.com/apache/knox/pull/57#discussion_r259449645
##########
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##########
@@ -160,8 +179,17 @@ public void init( FilterConfig filterConfig ) throws
ServletException {
} else {
clientName = clientNameParameter;
}
+
+ /* special handling for Azure AD, use path separators instead of query
params */
+ clients.forEach( client -> {
+ if(client.getName().equalsIgnoreCase(PAC4J_AZURE_AD_CLIENT)) {
+ ((AzureAdClient)client).setCallbackUrlResolver(new
PathParameterCallbackUrlResolver());
Review comment:
`PAC4J_AZURE_AD_CLIENT` - seems weird to me. I think this needs to match the
name of the `AzureAdClient` class? Can we do something like
`AzureAdClient.class.getName()` instead of the magic constant?
Commenting here since this is where it finally made sense that the value of
`PAC4J_AZURE_AD_CLIENT` should match `AzureAdClient`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
