[
https://issues.apache.org/jira/browse/KNOX-1828?focusedWorklogId=214358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214358
]
ASF GitHub Bot logged work on KNOX-1828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/19 03:50
Start Date: 17/Mar/19 03:50
Worklog Time Spent: 10m
Work Description: shawnweeks commented on pull request #75: KNOX-1828 Fix
Websocket Message Size
URL: https://github.com/apache/knox/pull/75
Resolves issue with Zeppelin and websocket messages being capped at 65,536
bytes.
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull request?
Set websocket container max text and binary message sizes to
Integer.MAX_VALUE.
## How was this patch tested?
(Please explain how this patch was tested. For instance: running automated
unit/integration tests, manual tests. Please write down your test steps as
detailed as possible)
Create workbook in zeppelin that returns more than 65,536 bytes of data. I
used a sql query from Phoenix but anything that makes a big message should work.
After proxying through Knox page never completes loading and Knox spams
error logs with message too large.
(If this patch involves UI changes, please attach a screen-shot; otherwise,
remove this)
Please review [Knox Contributing
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 214358)
Time Spent: 10m
Remaining Estimate: 0h
> Websocket Parameters Not Being Applied
> --------------------------------------
>
> Key: KNOX-1828
> URL: https://issues.apache.org/jira/browse/KNOX-1828
> Project: Apache Knox
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Shawn Weeks
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It looks like the gateway.websocket parameters are not making it back to
> Jetty. Knox set's this parameter to Integer.MAX_VALUE and setting the
> parameters like the following have no effect.
> {code:java}
> <property>
> <name>gateway.websocket.input.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.size</name>
> <value>1048576</value>
> </property>
> {code}
>
>
> {code:java}
> 2019-03-16 16:11:43,548 ERROR gateway.websockets
> (ProxyWebSocketAdapter.java:cleanupOnError(171)) - Error:
> org.eclipse.jetty.websocket.api.MessageTooLargeException: Resulting message
> size [73,728] is too large for configured max of [65,536]
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
