[
https://issues.apache.org/jira/browse/KNOX-1828?focusedWorklogId=214772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214772
]
ASF GitHub Bot logged work on KNOX-1828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 13:51
Start Date: 18/Mar/19 13:51
Worklog Time Spent: 10m
Work Description: shawnweeks commented on pull request #75: KNOX-1828 Fix
Websocket Message Size
URL: https://github.com/apache/knox/pull/75#discussion_r266447454
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -87,6 +87,8 @@ public void onWebSocketConnect(final Session
frontEndSession) {
* plumbing takes place
*/
container = ContainerProvider.getWebSocketContainer();
+ container.setDefaultMaxBinaryMessageBufferSize(Integer.MAX_VALUE);
+ container.setDefaultMaxTextMessageBufferSize(Integer.MAX_VALUE);
Review comment:
I can grab those from the frontEndSession. Originally I was trying to figure
out how to just set the policy on the container but as far as I can tell Jetty
doesn't provide a good way to do that. The backendSession is still use
Integer.MAX_VALUE from another effort. Should I try to set it as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 214772)
Time Spent: 40m (was: 0.5h)
> Websocket Parameters Not Being Applied
> --------------------------------------
>
> Key: KNOX-1828
> URL: https://issues.apache.org/jira/browse/KNOX-1828
> Project: Apache Knox
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 1.2.0
> Reporter: Shawn Weeks
> Priority: Minor
> Fix For: 1.3.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It looks like the gateway.websocket parameters are not making it back to
> Jetty. Knox set's this parameter to Integer.MAX_VALUE and setting the
> parameters like the following have no effect.
> {code:java}
> <property>
> <name>gateway.websocket.input.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.size</name>
> <value>1048576</value>
> </property>
> {code}
>
>
> {code:java}
> 2019-03-16 16:11:43,548 ERROR gateway.websockets
> (ProxyWebSocketAdapter.java:cleanupOnError(171)) - Error:
> org.eclipse.jetty.websocket.api.MessageTooLargeException: Resulting message
> size [73,728] is too large for configured max of [65,536]
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
