[
https://issues.apache.org/jira/browse/KNOX-1828?focusedWorklogId=214801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214801
]
ASF GitHub Bot logged work on KNOX-1828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 14:43
Start Date: 18/Mar/19 14:43
Worklog Time Spent: 10m
Work Description: moresandeep commented on issue #75: KNOX-1828 Fix
Websocket Message Size
URL: https://github.com/apache/knox/pull/75#issuecomment-473939005
> @moresandeep That will fix the backendsession but to fix the container
I'll have to explicity cast it ClientContainer and modify the policy because
ContainerProvider.getWebSocketContainer() and the Jetty code behind it sets the
defaults.
Sorry, I did not get it, what I mean is this, in the ProxyWebSocketAdapter
class, pass a map of gateway config variables, something like
<pre>
public ProxyWebSocketAdapter(final URI backend, final ExecutorService pool,
final ClientEndpointConfig clientConfig, final Map<String, Long> config) {
super();
this.backend = backend;
this.pool = pool;
this.clientConfig = clientConfig;
this.gatewayConfig = config;
}
</pre>
then in `public void onWebSocketConnect(final Session frontEndSession)`
you can have
`container.setAsyncSendTimeout(gatewayConfig.get(DEFAULT_WEBSOCKET_MAX_TEXT_MESSAGE_BUFFER_SIZE));`
.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 214801)
Time Spent: 1.5h (was: 1h 20m)
> Websocket Parameters Not Being Applied
> --------------------------------------
>
> Key: KNOX-1828
> URL: https://issues.apache.org/jira/browse/KNOX-1828
> Project: Apache Knox
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 1.2.0
> Reporter: Shawn Weeks
> Priority: Minor
> Fix For: 1.3.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> It looks like the gateway.websocket parameters are not making it back to
> Jetty. Knox set's this parameter to Integer.MAX_VALUE and setting the
> parameters like the following have no effect.
> {code:java}
> <property>
> <name>gateway.websocket.input.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.size</name>
> <value>1048576</value>
> </property>
> {code}
>
>
> {code:java}
> 2019-03-16 16:11:43,548 ERROR gateway.websockets
> (ProxyWebSocketAdapter.java:cleanupOnError(171)) - Error:
> org.eclipse.jetty.websocket.api.MessageTooLargeException: Resulting message
> size [73,728] is too large for configured max of [65,536]
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
