smolnar82 commented on a change in pull request #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#discussion_r321696171
########## File path: gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java ########## @@ -57,6 +61,12 @@ private ExecutorService pool; + /* Message buffer for holding data frames temporarily in memory till connection is setup. + Keeping the max size of the buffer as 100 messages for now. */ + private List<String> messageBuffer; Review comment: You may consider instantiating the List here and check for emptiness in the below code instead of null checks. Less code and less error-prone. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
