smolnar82 commented on a change in pull request #143: KNOX-1997: Adding changes
to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r322751828
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -64,7 +65,7 @@
/* Message buffer for holding data frames temporarily in memory till
connection is setup.
Keeping the max size of the buffer as 100 messages for now. */
private List<String> messageBuffer = new ArrayList<String>();
- private static final int MAX_BUFFER_MESSAGE_COUNT = 100;
+ private int maxMessageBufferCount =
GatewayConfigImpl.DEFAULT_WEBSOCKET_MAX_WAIT_BUFFER_COUNT;
Review comment:
You can have a new final class member; initialized when creating the
instance (through the constructor).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
