smolnar82 commented on a change in pull request #143: KNOX-1997: Adding changes
to buffer messages from backend in onMessag…
URL: https://github.com/apache/knox/pull/143#discussion_r322229215
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/GatewayWebsocketHandler.java
##########
@@ -117,7 +117,10 @@ public Object createWebSocket(ServletUpgradeRequest req,
final String backendURL = getMatchedBackendURL(path);
/* Upgrade happens here */
- return new ProxyWebSocketAdapter(URI.create(backendURL), pool,
getClientEndpointConfig(req));
+ ProxyWebSocketAdapter wsAdaptor = new ProxyWebSocketAdapter
+ (URI.create(backendURL), pool, getClientEndpointConfig(req));
+ wsAdaptor.setMaxBufferCount(config.getWebsocketMaxWaitBufferCount());
Review comment:
I believe we do not need this API at all; you should just use
`config.getWebsocketMaxWaitBufferCount()` within `ProxyWebSocketAdapter` when
checking the limit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
