risdenk commented on a change in pull request #239: KNOX-2153 - CM discovery -
Monitor Cloudera Manager
URL: https://github.com/apache/knox/pull/239#discussion_r368155895
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscovery.java
##########
@@ -105,6 +116,34 @@ private DiscoveryApiClient
getClient(ServiceDiscoveryConfig discoveryConfig) {
return client;
}
+ /**
+ * Get the ClouderaManager configuration change monitor from the associated
gateway service.
+ */
+ private ClouderaManagerClusterConfigurationMonitor
getConfigurationChangeMonitor() {
Review comment:
I thought GatewayServices is already a public static object that is
accessible from GatewayServer or elsewhere. I don't think we need to go through
all this effort to try to use reflection here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
