risdenk commented on a change in pull request #239: KNOX-2153 - CM discovery -
Monitor Cloudera Manager
URL: https://github.com/apache/knox/pull/239#discussion_r368154377
##########
File path: build-tools/src/main/resources/build-tools/spotbugs-filter.xml
##########
@@ -71,4 +71,9 @@ limitations under the License.
<Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS" />
</Match>
+ <Match>
+ <Class
name="org.apache.knox.gateway.topology.discovery.cm.ClouderaManagerClusterConfigurationMonitor"
/>
+ <Bug pattern="OBJECT_DESERIALIZATION" />
Review comment:
This is super concerning. If this is required (I'm not sure it is based on
looking at this class), can this be limited to a single method instead of the
whole class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
