smolnar82 commented on a change in pull request #239: KNOX-2153 - CM discovery - Monitor Cloudera Manager URL: https://github.com/apache/knox/pull/239#discussion_r368864779
########## File path: gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerClusterConfigurationMonitor.java ########## @@ -0,0 +1,940 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.knox.gateway.topology.discovery.cm; + +import com.cloudera.api.swagger.EventsResourceApi; +import com.cloudera.api.swagger.RolesResourceApi; +import com.cloudera.api.swagger.ServicesResourceApi; +import com.cloudera.api.swagger.client.ApiClient; +import com.cloudera.api.swagger.client.ApiException; +import com.cloudera.api.swagger.model.ApiConfig; +import com.cloudera.api.swagger.model.ApiConfigList; +import com.cloudera.api.swagger.model.ApiEvent; +import com.cloudera.api.swagger.model.ApiEventAttribute; +import com.cloudera.api.swagger.model.ApiEventCategory; +import com.cloudera.api.swagger.model.ApiEventQueryResult; +import com.cloudera.api.swagger.model.ApiRole; +import com.cloudera.api.swagger.model.ApiRoleList; +import com.cloudera.api.swagger.model.ApiServiceConfig; +import org.apache.commons.io.FileUtils; +import org.apache.knox.gateway.config.GatewayConfig; +import org.apache.knox.gateway.i18n.messages.MessagesFactory; +import org.apache.knox.gateway.services.security.AliasService; +import org.apache.knox.gateway.topology.discovery.ClusterConfigurationMonitor; +import org.apache.knox.gateway.topology.discovery.ServiceDiscoveryConfig; + +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.io.ObjectInputStream; +import java.io.ObjectOutputStream; +import java.io.OutputStream; +import java.io.Serializable; +import java.nio.file.Files; +import java.text.DateFormat; +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Properties; +import java.util.Set; +import java.util.TimeZone; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.locks.ReadWriteLock; +import java.util.concurrent.locks.ReentrantReadWriteLock; + +/** + * ClusterConfigurationMonitor implementation for clusters managed by ClouderaManager. + */ +public class ClouderaManagerClusterConfigurationMonitor implements ClusterConfigurationMonitor { + + private static final String TYPE = "CM"; + + private static final String CLUSTERS_DATA_DIR_NAME = TYPE + "-clusters"; + + private static final String PERSISTED_FILE_COMMENT = "Generated File. Do Not Edit!"; + + private static final String PROP_CLUSTER_PREFIX = "cluster."; + private static final String PROP_CLUSTER_SOURCE = PROP_CLUSTER_PREFIX + "source"; + private static final String PROP_CLUSTER_NAME = PROP_CLUSTER_PREFIX + "name"; + private static final String PROP_CLUSTER_USER = PROP_CLUSTER_PREFIX + "user"; + private static final String PROP_CLUSTER_ALIAS = PROP_CLUSTER_PREFIX + "pwd.alias"; + + private static final ClouderaManagerServiceDiscoveryMessages log = + MessagesFactory.get(ClouderaManagerServiceDiscoveryMessages.class); + + + // The format of the filter employed when restart events are queried from ClouderaManager + private static final String RESTART_EVENTS_QUERY_FORMAT = "category==" + ApiEventCategory.AUDIT_EVENT.getValue() + + ";attributes.command==Restart" + + ";attributes.command_status==SUCCEEDED" + + ";attributes.cluster==\"%s\"%s"; + + // The format of the timestamp element of the restart events query filter + private static final String EVENTS_QUERY_TIMESTAMP_FORMAT = ";timeOccurred=gt=%s"; + + // The default amount of time before "now" the monitor will check for restart events the first time + private static final long DEFAULT_EVENT_QUERY_DEFAULT_TIMESTAMP_OFFSET = (60 * 60 * 1000); // one hour + + // ISO 8601 datetime format for restart event query filtering + private DateFormat eventQueryTimestampFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm'Z'", Locale.getDefault()); Review comment: `SimpleDateFormat` is not thread-safe; you may consider binding it to local thread. See one sample [here](https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/GatewayServerLifecycleListener.java#L38). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
