pzampino commented on issue #239: KNOX-2153 - CM discovery - Monitor Cloudera Manager URL: https://github.com/apache/knox/pull/239#issuecomment-576976964 > The biggest concern I have is the java serialization that doesn't seem entirely necessary. > > The other item that seems confusing is there a bunch of `model/*` cleanup as far as constants and fixing variables. It would be cleaner to separate this so its easier to tell exactly what changed for monitoring the CM API. I believe I've addressed the object serialization concerns, and the ServiceModel changes are intended to facilitate the determination of relevant config changes. The constants were added because the values are now being referenced in multiple places.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
