risdenk commented on a change in pull request #239: KNOX-2153 - CM discovery -
Monitor Cloudera Manager
URL: https://github.com/apache/knox/pull/239#discussion_r369830514
##########
File path:
gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscoveryTest.java
##########
@@ -331,6 +331,17 @@ public void testLivyDiscoverySSL() {
assertEquals("https://"; + hostName + ":" + port, livyURLs.get(0));
}
+ @Test
+ public void testLivyDiscoveryWhenTransportModeIsBinary() {
+ final String hostName = "livy-host";
+ final String port = "8998";
+ ServiceDiscovery.Cluster cluster = doTestLivyDiscovery(hostName, port,
false, "binary");
Review comment:
This doesn't make much sense to me. Livy discovery should be on the HTTP
endpoint. Binary vs HTTP would be on the thrift server not on the HTTP
endpoint....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
