risdenk commented on a change in pull request #239: KNOX-2153 - CM discovery - 
Monitor Cloudera Manager
URL: https://github.com/apache/knox/pull/239#discussion_r369830892
 
 

 ##########
 File path: 
gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscoveryTest.java
 ##########
 @@ -988,8 +999,17 @@ private void doTestSolrDiscovery(final boolean isSSL) {
   private ServiceDiscovery.Cluster doTestLivyDiscovery(final String  hostName,
                                                        final String  port,
                                                        final boolean isSSL) {
+    return doTestLivyDiscovery(hostName, port, isSSL, "http");
+  }
+
+
+  private ServiceDiscovery.Cluster doTestLivyDiscovery(final String  hostName,
+                                                       final String  port,
+                                                       final Boolean isSSL,
+                                                       final String  
transportMode) {
     // Configure the role
     Map<String, String> roleProperties = new HashMap<>();
+    roleProperties.put("livy_server_thrift_transport_mode", transportMode);
 
 Review comment:
   We shouldn't care about this. Livy has a thrift server which is completely 
separate from the HTTP API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to