risdenk commented on a change in pull request #274: KNOX-2212 - Token
permissiveness
URL: https://github.com/apache/knox/pull/274#discussion_r384133140
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##########
@@ -118,9 +125,17 @@ public void addToken(final String token,
@Override
public long getTokenExpiration(final String token) throws
UnknownTokenException {
long expiration;
-
- validateToken(token);
-
+ try {
+ validateToken(token);
+ } catch (final UnknownTokenException e) {
+ /* if token permissiveness is enabled we check JWT token expiration when
the token state is unknown */
+ if (permissiveFailureEnabled && StringUtils
Review comment:
We do the exact same thing twice? Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
