moresandeep commented on a change in pull request #274: KNOX-2212 - Token
permissiveness
URL: https://github.com/apache/knox/pull/274#discussion_r384772404
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##########
@@ -118,9 +125,17 @@ public void addToken(final String token,
@Override
public long getTokenExpiration(final String token) throws
UnknownTokenException {
long expiration;
-
- validateToken(token);
-
+ try {
+ validateToken(token);
+ } catch (final UnknownTokenException e) {
+ /* if token permissiveness is enabled we check JWT token expiration when
the token state is unknown */
+ if (permissiveFailureEnabled && StringUtils
Review comment:
Actually moving this code in a separate function would be more untidy
(common code in this case would be just `validateToken(token)` and try catch).
I don't like the fact that `validateToken(token)` throws an exception instead
of returning `true` or `false` that would be a major change to do here. The
main function that calculates JWT value `getJWTTokenExpiration(token)` is
common for both implementation. Let me know if you still feel strongly about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
