moresandeep commented on a change in pull request #274: KNOX-2212 - Token
permissiveness
URL: https://github.com/apache/knox/pull/274#discussion_r384168240
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##########
@@ -310,4 +325,30 @@ protected boolean needsEviction(final String token)
throws UnknownTokenException
return tokenExpirations.keySet().stream().collect(Collectors.toList());
}
+ /**
+ * A function that returns the JWT token expiration. This is only called when
+ * gateway.knox.token.permissive.failure.enabled property is set to true.
+ *
+ * @param token token to be verified and saved
+ */
+ protected long getJWTTokenExpiration(final String token) {
+ if (!isValidIdentifier(token)) {
+ throw new IllegalArgumentException("Token data cannot be null.");
+ }
+ JWT jwt;
+ try {
+ jwt = new JWTToken(token);
+ } catch (final ParseException e) {
+ log.errorParsingToken(e.toString());
+ throw new IllegalArgumentException(e);
Review comment:
True, that would be ugly, but we only throw two types of exceptions here
`UnknownTokenException ` and `IllegalArgumentException`. `ParseException` is
not a Runtime exception so we need to wrap it up in one of the two types, which
leaves us with `IllegalArgumentException`. The stack trace will atleast let
users know what the original error was.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
