risdenk commented on a change in pull request #274: KNOX-2212 - Token permissiveness URL: https://github.com/apache/knox/pull/274#discussion_r385221731
########## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java ########## @@ -16,15 +16,19 @@ */ package org.apache.knox.gateway.services.token.impl; +import org.apache.commons.lang3.StringUtils; Review comment: It was more around removing the commons-lang3 dependency if it could be avoided. I only bring it up if we don't need commons-lang3 everywhere. commons-lang3 wasn't added in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
