[ 
https://issues.apache.org/jira/browse/KNOX-2731?focusedWorklogId=756237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756237
 ]

ASF GitHub Bot logged work on KNOX-2731:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/22 08:26
            Start Date: 13/Apr/22 08:26
    Worklog Time Spent: 10m 
      Work Description: zeroflag commented on code in PR #554:
URL: https://github.com/apache/knox/pull/554#discussion_r849217236


##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -228,6 +235,9 @@ public void init() throws AliasServiceException, 
ServiceLifecycleException, KeyL
       }
     }
 
+    String shouldIncludeGroupsParam = 
context.getInitParameter(TOKEN_INCLUDE_GROUPS_IN_JWT);
+    shouldIncludeGroups = shouldIncludeGroupsParam == null ? false : 
Boolean.parseBoolean(shouldIncludeGroupsParam);

Review Comment:
   We can remove it from there. It only serves as "documentation" of a new 
config parameter.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 756237)
    Time Spent: 1h  (was: 50m)

> Allow group membership information to be included in issued JWTs
> ----------------------------------------------------------------
>
>                 Key: KNOX-2731
>                 URL: https://issues.apache.org/jira/browse/KNOX-2731
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to