[
https://issues.apache.org/jira/browse/KNOX-2731?focusedWorklogId=756270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756270
]
ASF GitHub Bot logged work on KNOX-2731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/22 09:18
Start Date: 13/Apr/22 09:18
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #554:
URL: https://github.com/apache/knox/pull/554#discussion_r849266857
##########
gateway-server/src/test/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateServiceTest.java:
##########
@@ -369,16 +370,7 @@ protected TokenStateService createTokenStateService()
throws Exception {
/* create a test JWT token */
protected JWT getJWTToken(final long expiry) {
- String[] claims = new String[6];
- claims[0] = "KNOXSSO";
- claims[1] = "[email protected]";
- claims[2] = "https://login.example.com";;
- if(expiry > 0) {
- claims[3] = Long.toString(expiry);
- }
- claims[4] = "E0LDZulQ0XE_otJ5aoQtQu-RnXv8hU-M9U4dD7vDioA";
- claims[5] = null;
- JWT token = new JWTToken("RS256", claims);
+ JWT token = new JWTToken(new
JWTokenAttributesBuilder().setExpires(expiry).setAlgorithm("RS256").build());
Review Comment:
Putting it back or removing it makes no difference. These attributes are not
checked in this test. `JWTTokenTest` covers the attribute checks.
Issue Time Tracking
-------------------
Worklog Id: (was: 756270)
Time Spent: 1h 50m (was: 1h 40m)
> Allow group membership information to be included in issued JWTs
> ----------------------------------------------------------------
>
> Key: KNOX-2731
> URL: https://issues.apache.org/jira/browse/KNOX-2731
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
